Skip to content

separate standalone amuse-units package#634

Open
rieder wants to merge 3 commits into
amusecode:mainfrom
rieder:units-package
Open

separate standalone amuse-units package#634
rieder wants to merge 3 commits into
amusecode:mainfrom
rieder:units-package

Conversation

@rieder

@rieder rieder commented Jun 2, 2020

Copy link
Copy Markdown
Member

No description provided.

@rieder rieder requested a review from ipelupessy June 2, 2020 12:16
@rieder

rieder commented Jun 2, 2020

Copy link
Copy Markdown
Member Author

installing amuse-units and then amuse-framework seems to work for me, as does installing just amuse-units.

@ipelupessy

Copy link
Copy Markdown
Member

ok, but I think amuse units component themselves need some work to remove e.g. the amuse exceptions etc

@ipelupessy

Copy link
Copy Markdown
Member

I think the exceptions can be converted to normal exceptions, however there is also some support utilities used (late, memoization

@rieder

rieder commented Jun 2, 2020

Copy link
Copy Markdown
Member Author

I'll check. For many of those I don't think I know what they do...

@ipelupessy

Copy link
Copy Markdown
Member

i think late does what functools cached_property (introduced in 3.8) does and the memoization is lru_cache (3.3 or so)

@rieder

rieder commented Jun 2, 2020

Copy link
Copy Markdown
Member Author

Ok. I'm not yet happy with a 3.8 dependency but 3.3 is certainly fine.

@ipelupessy

Copy link
Copy Markdown
Member

memoization speeds up the unit module considerably, the late stuff I have never really seen what it adds though

@rieder

rieder commented Jun 2, 2020

Copy link
Copy Markdown
Member Author

memoization speeds up the unit module considerably

Ah, I see. I guess it should have been memorize :). I'll see if I can replace that.

@rieder

rieder commented Jun 2, 2020

Copy link
Copy Markdown
Member Author

lru_cache is not a simple drop-in replacement unfortunately... needs a bit more work.

@rieder

rieder commented Jun 2, 2020

Copy link
Copy Markdown
Member Author

here's a description of how lru_cache could work for methods... not sure I like this. https://stackoverflow.com/questions/33672412/python-functools-lru-cache-with-class-methods-release-object

@ipelupessy

Copy link
Copy Markdown
Member

just copying the necessary bits is always an option...

@ipelupessy

Copy link
Copy Markdown
Member

(ie just putting the late and memoization bits also in units) with a comment and view of replacing them with standard constructs...

@stale

stale Bot commented Mar 4, 2022

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the status: wontfix label Mar 4, 2022
@ipelupessy ipelupessy added status: keep-open This issue should not be auto-closed by the bot and removed status: wontfix labels Mar 5, 2022
@ipelupessy

Copy link
Copy Markdown
Member

keep open

@stale

stale Bot commented May 4, 2022

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 28 days if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the status: stale Issues that have been around for a while without updates label May 4, 2022
@rieder rieder removed the status: stale Issues that have been around for a while without updates label May 12, 2022
@stale

stale Bot commented Nov 18, 2025

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 365 days if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the stale label Nov 18, 2025
@HannoSpreeuw HannoSpreeuw moved this from Backlog to Open PRs in Development Board Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale status: keep-open This issue should not be auto-closed by the bot

Projects

Status: Open PRs

Development

Successfully merging this pull request may close these issues.

3 participants